Install catkin-pkg on OS X using PIP #286
Conversation
thomas-moulard
requested review from
zmichaels11 and
prajakta-gokhale
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #286 +/- ##
=======================================
Coverage 93.37% 93.37%
=======================================
Files 8 8
Lines 151 151
Branches 10 10
=======================================
Hits 141 141
Misses 10 10
Continue to review full report at Codecov.
|
thomas-moulard
force-pushed
the
tmoulard/pip_catkin_osx
branch
from
62bf9a6 to
6af93e9
Compare
Signed-off-by: Thomas Moulard <tmoulard@amazon.com>
thomas-moulard
force-pushed
the
tmoulard/pip_catkin_osx
branch
from
6af93e9 to
cacd2a3
Compare
|
This fixes the action-ros-ci build failures on OS X: ros-tooling/action-ros-ci#387 |
| @@ -5962,7 +6027,7 @@ function runOsX() { | |||
| yield pip.installPython3Dependencies(); | |||
| // While rosdep and vcs are available as a Debian package on Ubuntu, they need | |||
| // to be installed through pip on OS X. | |||
| yield pip.runPython3PipInstall(["rosdep", "vcstool"]); | |||
| yield pip.runPython3PipInstall(["catkin-pkg", "rosdep", "vcstool"]); | |||
There was a problem hiding this comment.
I am not entirely sure about this, but isnt this built automatically by npm run build or its equivalent? Shouldnt the change in src/setup-ros-osx.ts be enough?
There was a problem hiding this comment.
No, we need to commit the generated file too.
| @@ -27,7 +27,7 @@ export async function runOsX() { | |||
|
|
|||
| // While rosdep and vcs are available as a Debian package on Ubuntu, they need | |||
| // to be installed through pip on OS X. | |||
| await pip.runPython3PipInstall(["rosdep", "vcstool"]); | |||
| await pip.runPython3PipInstall(["catkin-pkg", "rosdep", "vcstool"]); | |||
There was a problem hiding this comment.
Looks like this install was missing, but I'm confused as to how this was not failing earlier?
|
I don't know why it started failing but DIrks' answer to someone with a similar issue is that it's working as intended and that installing catkin-pkg is mentioned in the doc: ros2/ros2#503 |
Description