Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modify macos ci #675

Merged
merged 7 commits into from
Apr 30, 2024
Merged

fix: modify macos ci #675

merged 7 commits into from
Apr 30, 2024

Conversation

wep21
Copy link
Contributor

@wep21 wep21 commented Apr 28, 2024

This PR fixes:

- ModuleNotFoundError: No module named 'distutils'
- note: If you believe this is a mistake, please contact your Python installation or OS distribution provider. You can override this, at the risk of breaking your Python installation or OS, by passing --break-system-packages.
  hint: See PEP 668 for the detailed specification.

It also pins Python to 3.10 as per REP 2000: https://www.ros.org/reps/rep-2000.html#rolling-ridley-june-2020-ongoing

  • remove python3.12 installed in github actions runner
  • remove python3.12 installed by brew
  • link pip3.10 to pip3 because python3.10 installed by brew doesn't have pip3 link

@wep21 wep21 requested a review from a team as a code owner April 28, 2024 05:48
@wep21 wep21 requested review from gbiggs and christophebedard and removed request for a team April 28, 2024 05:48
src/package_manager/pip.ts Outdated Show resolved Hide resolved
src/package_manager/pip.ts Outdated Show resolved Hide resolved
wep21 and others added 6 commits April 30, 2024 01:11
Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
Co-authored-by: Christophe Bedard <bedard.christophe@gmail.com>
Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
Co-authored-by: Christophe Bedard <bedard.christophe@gmail.com>
Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
This reverts commit 4344279.

Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
@christophebedard
Copy link
Member

It's still using the system Python 3.12 even though we're installing 3.10: https://github.com/ros-tooling/setup-ros/actions/runs/8881922426/job/24385408636?pr=675#step:5:1251. Some possible solutions:

  1. Uninstall 3.12?
  2. Change PATH to point to the 3.10 installation: https://apple.stackexchange.com/a/450306. However, we'd need to do that in action-ros-ci too, so that's a bit annoying.
  3. Change the system python/python3 executables to point to python3.10.

@christophebedard
Copy link
Member

christophebedard commented Apr 29, 2024

Looks like it still has some Python 3.12 stuff: https://github.com/ros-tooling/setup-ros/actions/runs/8882209200/job/24386325507?pr=675#step:5:1274.

I'm guessing /Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/ is the system installation.

Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
@christophebedard
Copy link
Member

I just want to confirm that you're happy with this. CI passes and I don't see any references to the system python3.12 anymore.

@wep21
Copy link
Contributor Author

wep21 commented Apr 30, 2024

The changes are

  • remove python3.12 installed in github actions runner
  • remove python3.12 installed by brew
  • link pip3.10 to pip3 because python3.10 installed by brew doesn't have pip3 link

@wep21
Copy link
Contributor Author

wep21 commented Apr 30, 2024

For now, it is unnecessary to make break-system-package true because it is necessary for python3.12.
@christophebedard Do you think the change should remain?

@christophebedard
Copy link
Member

I think it's fine, we can leave it there.

Copy link
Member

@christophebedard christophebedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix and for the perseverance! 😁

@christophebedard christophebedard merged commit 1692fc1 into ros-tooling:master Apr 30, 2024
20 checks passed
@christophebedard
Copy link
Member

I released this as 0.7.4/v0.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants