Skip to content
This repository has been archived by the owner on Jun 10, 2021. It is now read-only.

Fix build error and warning with latest version of core #192

Merged
merged 1 commit into from
Dec 29, 2020

Conversation

emersonknapp
Copy link
Contributor

After ros2/rclcpp#1442 - RCLCPP_DEBUG no longer accepts std::string, so we need to update those places to pass const char *.

(side note there was a build warning for the other string format - and I didn't want to have a PR with warnings)

Signed-off-by: Emerson Knapp <eknapp@amazon.com>
@emersonknapp emersonknapp requested a review from a team as a code owner December 28, 2020 23:15
@emersonknapp emersonknapp requested review from Karsten1987 and jikawa-az and removed request for a team December 28, 2020 23:15
@codecov
Copy link

codecov bot commented Dec 29, 2020

Codecov Report

Merging #192 (ef625d3) into master (bf375a5) will decrease coverage by 5.28%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #192       +/-   ##
===========================================
- Coverage   34.62%   29.34%    -5.29%     
===========================================
  Files        3012       42     -2970     
  Lines      144506     1847   -142659     
  Branches    91701      918    -90783     
===========================================
- Hits        50042      542    -49500     
+ Misses       8464      445     -8019     
+ Partials    86000      860    -85140     
Flag Coverage Δ
unittests 29.34% <ø> (-5.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...etrics_collector/test_linux_memory_measurement.cpp
...llector/src/system_metrics_collector/utilities.cpp
...trics_collector/test_metrics_message_publisher.cpp
...m_metrics_collector/test_linux_cpu_measurement.cpp
...r/test/system_metrics_collector/test_utilities.cpp
...or/src/topic_statistics_collector/dummy_talker.cpp
...lector/test_linux_process_cpu_measurement_node.cpp
...or/src/topic_statistics_collector/dummy_talker.cpp
...ctor/src/system_metrics_collector/example_main.cpp
...ollector/linux_process_memory_measurement_node.cpp
... and 3020 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf375a5...ef625d3. Read the comment docs.

@emersonknapp emersonknapp merged commit 2e352ad into master Dec 29, 2020
@emersonknapp emersonknapp deleted the emersonknapp/fix-logging branch December 29, 2020 00:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants