porting rqt_console to ros2 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brawner
reviewed
Nov 19, 2018
src/rqt_console/console.py
Outdated
| @@ -82,6 +83,8 @@ def __init__(self, context): | |||
|
|
|||
| self._subscriber = None | |||
| self._topic = '/rosout_agg' | |||
| self._node = rclpy.create_node('rqt_console') | |||
There was a problem hiding this comment.
This should make use of the new ros2_plugin_context._node
mlautman
force-pushed
the
ros2-port
branch
4 times, most recently
from
55a5211
to
79dfb27
Compare
mlautman
added a commit
that referenced
this pull request
Nov 29, 2018
* porting rqt_console to ros2 * changing default values in log msg type to match PR
mlautman
added a commit
that referenced
this pull request
Nov 30, 2018
* porting rqt_console to ros2 * changing default values in log msg type to match PR
dirk-thomas
reviewed
Dec 12, 2018
| find_package(ament_cmake REQUIRED) | ||
| find_package(ament_cmake_python REQUIRED) | ||
| # Note: This is needed for rcl_interfaces Log.msg | ||
| find_package(rcl_interfaces REQUIRED) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports rqt_console to ros2
This port uses the log msg defined here: https://github.com/ros2/rcl_interfaces/blob/dc61c47dca17e2ee5f8f30993054c5c75a050ea3/rcl_interfaces/msg/Log.msg
Log msg pr: ros2/rcl_interfaces#53
issue: ros2/rcl_interfaces#50
It also depends on: ros-visualization/rqt#161