Added error handling for dynamic_reconfigure exceptions #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cottsay FYI. Please take a look at the patch when you find some time. |
|
Ack, I'll make a note so I don't forget. Thanks. |
|
@dirk-thomas, can you make me a contributor for this repo? Doesn't look like I can change the assignment or accept the PR or anything. Thanks! |
|
@cottsay Done. |
cottsay
approved these changes
Jul 7, 2017
|
@cottsay As the maintainer you are now in charge of (squash) merging PRs and also decide when to make new releases with bloom for all the available ROS distros in order to make the fixes available to users not building from source. |
cottsay
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to update the configuration of a node via dynamic_reconfigure two exceptions could be raised and weren't catched.
dynamic_reconfigure.DynamicReconfigureParameterException: don't know parameter: ....and
rospy.service.ServiceException: service [/node .../set_parameters] unavailableThe later one is gets raised because dynamic_reconfigure is not catching it itself and reraising its own exception. I will also issue a PR for the reraising at the dynamic_reconfigure project.
Besides the catches for the occurring exceptions I also already added the catch for the exception I expected will be raised once the PR might have been merged in dynamic_reconfigure.