Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a consistent formatting method when logging #49

Merged
merged 1 commit into from
Jul 31, 2019
Merged

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Jul 31, 2019

This will improve logging function compatibility between ROS 1 and ROS 2.

Right now, some log statements cause an exception in ROS 2 due to the differing signatures. This unification will resolve that.

This will improve logging function compatibility between ROS 1 and ROS
2.

Signed-off-by: Scott K Logan <logans@cottsay.net>
@cottsay cottsay added the bug label Jul 31, 2019
@cottsay cottsay requested a review from gonzodepedro July 31, 2019 18:56
@cottsay cottsay self-assigned this Jul 31, 2019
Copy link
Collaborator

@gonzodepedro gonzodepedro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cottsay cottsay merged commit 6aada93 into master Jul 31, 2019
@cottsay cottsay deleted the log_format branch July 31, 2019 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants