ColorEditor: maintain edited text + cursor pos (#1609)

ros-visualization · Apr 8, 2021 · 1872e34 · 1872e34
1 parent 5a9631d
commit 1872e34
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/rviz/properties/color_editor.cpp b/src/rviz/properties/color_editor.cpp
@@ -78,13 +78,18 @@ void ColorEditor::resizeEvent(QResizeEvent* event)
 
 void ColorEditor::parseText()
 {
-  QColor new_color = parseColor(text());
+  const QString t = text();
+  QColor new_color = parseColor(t);
   if (new_color.isValid())
   {
     color_ = new_color;
     if (property_)
     {
+      auto pos = cursorPosition();
       property_->setColor(new_color);
+      // setColor() normalizes the text display and thus looses cursor pos
+      setText(t);             // thus: restore original, unnormalized text
+      setCursorPosition(pos); // as well as cursor position
     }
   }
 }