hiding small wrenches should be optional #1196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mall forces/torques optional
|
@wjwwood friendly ping. This has been discussed in the issue, CI succeeded and it works perfectly in our setup. Would be great to see this merged soon. |
|
@jgueldenstein, @v4hn thank you for the PR addressing #1081 This change will break ABI (because it adds a member to the |
dhood
approved these changes
Apr 7, 2018
|
fair enough, thank you!
|
|
Melodic is only failing due to a (now fixed) deprecation warning unrelated to this pr. So I'll merge. |
ghost
removed
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default behavior for wrench messages was to hide the visualization if the length of the vector was smaller than the width. This pull request adds a boolean property to enable/disable this feature as discussed in #1081.
I also renamed the function
updateColorAndAlpha()toupdateProperties(). The name made no sense anymore (even before) because scale and width are also updated here. The new name clarifies that several properties are updated.@v4hn