feat: Configurable tool button style melodic #1309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reinzor
changed the title
Also introduced separator between the toolbar actions and the static buttons. Clarifies the separation and this way we can keep the button ordening.
|
Can this one be merged as well? |
|
ping |
|
Can this one be merged as well? It is already merged in the kinetic branch .. |
|
Normally we do forward porting ourselves, unless there's significant changes required to forward port (normally we request pr's to the latest release branch instead and do backports, but didn't in this case). We do forward and back porting when we release, so this will get addressed then if not before. I cannot say right now when we'll do the next release though. In the meantime, maybe @chapulina has time to review and merge this one too since she did the original one as well. |
|
This is on my radar together with lots of other things. I'll try to get to it next week. 🤞 |
|
Okay, thanks for the update :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #1307 for melodic