feat: Configurable tool button style kinetic

[reinzor]

When using a lot of tools, it's annoying that not all tools fit in the default toolbar. This PR adds an additional tool menu (next to the remove tool menu) for configuring the tool button style: http://doc.qt.io/archives/qt-4.8/qt.html#ToolButtonStyle-enum

[chapulina]

Thanks for the PR, it looks generally good to me. Some details I noticed:

• The ➕ button is being affected by the settings, but not the ➖. It would be nice if they worked consistently.
• On text-only mode, the ➕ button disappears, but you can find it by hovering. It would be nice if it didn't disappear. It also looks weird with text on the side and below, because there's some whitespace for the empty text. Maybe the ➕ button should always be icon-only (i.e. it doesn't respond to style changes, like ➖ currently does).
• The toolbar style tool button itself can't be removed using the remove menu, it would be nice to give users this choice.

[reinzor]

Thanks for the review, I updated the PR in order to address your first two points. I don't know how to address the last point.

Now I clearly made a separation between the "actions" (added dynamically via the toolbar_manager) and the static tool buttons. If we want the user to also control the visibility of the static buttons, an additional menu should be added but I think this is beyond the scope of this PR.

[chapulina]

Thank you for addressing the comments. The separator is a nice touch! And I think that the clear separation means it's ok that the buttons to the right of the separator can't be added or removed.

I just have one final comment about ABI. I think it may be worth it running this branch through an ABI checker before merging, you could try it locally as explained here.

[reinzor]

Thanks for your comment, I updated both PR's to maintain the ABI

[wjwwood]

@dirk-thomas CI doesn't seem to be getting trigger now (previous commits on this pr were tested), what's the best way to debug it?

[dirk-thomas]

You need to use the default phrase of the Jenkins plugin: see https://plugins.jenkins.io/ghprb

@ros-pull-request-builder retest this please

Update: this comment has triggered the following builds: http://build.ros.org/view/Kpr/job/Kpr__rviz__ubuntu_xenial_amd64/220/ and http://build.ros.org/view/Kpr/job/Kpr__rviz__ubuntu_xenial_amd64/221/

[wjwwood]

@dirk-thomas it looks like it is rerunning CI on the second latest commit but no the latest.

[dirk-thomas]

it looks like it is rerunning CI on the second latest commit but no the latest.

No, the referenced checks in the GitHub UI are pointing to a build of the latest commit.

[wjwwood]

Weird, it didn't look like that before. Ok, well I dunno I guess it's working fine, thanks!

[chapulina]

Thanks @wjwwood and @dirk-thomas !