Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve cmdline parsing and add --fullscreen option #1413

Merged
merged 1 commit into from
Sep 1, 2019

Conversation

rhaschke
Copy link
Contributor

@rhaschke rhaschke commented Sep 1, 2019

Address #1260.

@rhaschke rhaschke merged commit 6c08d7e into ros-visualization:melodic-devel Sep 1, 2019
@rhaschke rhaschke deleted the fullscreen branch September 1, 2019 20:49
verbose = true;
std::cerr << "ERROR: the config file '" << display_config << "' is a .vcg file, which is the old rviz config format." << std::endl;
std::cerr << " New config files have a .rviz extension and use YAML formatting. The format changed" << std::endl;
std::cerr << " between Fuerte and Groovy. There is not (yet) an automated conversion program." << std::endl;
Copy link
Contributor

@simonschmeisser simonschmeisser Sep 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not (yet)

sounds optimistic 😉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, probably it's time to remove this check completely. I will do this for Noetic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants