Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fullscreen startup option #1097

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Conversation

paulerikf
Copy link
Contributor

This PR adds the "--fullscreen" command-line option, which allows rviz to start up in fullscreen mode. This flag is already in rviz1 - originally added by @rhaschke (Original PR).

@paulerikf paulerikf requested a review from ahcorde as a code owner November 20, 2023 23:22
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor comment

rviz_common/src/rviz_common/visualizer_app.cpp Outdated Show resolved Hide resolved
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Paul Erik Frivold <paulerikf@gmail.com>
@paulerikf
Copy link
Contributor Author

Great, thanks for taking a look. Should be o.k. now.

@paulerikf paulerikf requested a review from ahcorde November 27, 2023 20:54
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@paulerikf
Copy link
Contributor Author

@ahcorde Anything remaining for me to do to get this merged?

@ahcorde ahcorde merged commit d7b56b8 into ros2:rolling Nov 29, 2023
2 checks passed
@ahcorde
Copy link
Contributor

ahcorde commented Nov 29, 2023

Not really, merged! thank you for your contribution @paulerikf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants