Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable rviz -d my_config as shortcut to ~/.rviz/my_config.rviz #1422

Closed
wants to merge 1 commit into from
Closed

enable rviz -d my_config as shortcut to ~/.rviz/my_config.rviz #1422

wants to merge 1 commit into from

Conversation

v4hn
Copy link
Contributor

@v4hn v4hn commented Sep 6, 2019

Fixes #1420 .

@v4hn v4hn mentioned this pull request Sep 6, 2019
Closed
@v4hn v4hn force-pushed the pr-melodic-config-shortcut branch from 64b5e3c to ad0aa64 Compare September 6, 2019 14:23
rhaschke pushed a commit that referenced this pull request Sep 8, 2019
@v4hn @rhaschke
Enable rviz -d my_config as shortcut for ~/.rviz/my_config.rviz (#1422
779cbe8 
)
@rhaschke
Copy link
Contributor

rhaschke commented Sep 8, 2019

Merged as 779cbe8. Unfortunately, I wasn't able to push my simplifications to your PR branch.

@rhaschke rhaschke closed this Sep 8, 2019
@v4hn v4hn deleted the pr-melodic-config-shortcut branch September 8, 2019 16:32
@v4hn
Copy link
Contributor Author

v4hn commented Sep 8, 2019

Thank you! Your changes look good to me.
I intentionally did not accept rviz -d foo.rviz. But sure, I guess there's no reason not to.

Unfortunately, I wasn't able to push my simplifications to your PR branch.

Oh, I did not disable that intentionally.
Maybe the feature only works for private forks? I used my group's fork this time.

rhaschke added a commit to rhaschke/rviz that referenced this pull request Sep 29, 2019
@rhaschke
fix ros-visualization#1422: update to actual filename
44562c6 
To allow proper saving, the actually load filename needs to be stored as recent config.
rhaschke added a commit that referenced this pull request Sep 29, 2019
@rhaschke
fix #1422: update to actual filename
cd52242 
To allow proper saving, the actually load filename needs to be stored as recent config.
Otherwise, saving might overwrite a completely unrelated file in current working dir.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rviz -d xyz could look for ~/.rviz/xyz.rviz if xyz does not exist? [feature request]
2 participants
@v4hn @rhaschke