clang-format #1502
Merged
clang-format #1502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhaschke
force-pushed
the
clang-format
branch
5 times, most recently
from
728a7b8 to
52d1e1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are a lot of changes, I know. But the formatting was actually a nightmare, having tabs and spaces arbitrarily intermixed and don't following any coherent rules. I tried to tweak Dave's clang-format template as best as possible to the (most frequently used) style in rviz.
Travis will impose correct formatting in the future.
Nevertheless, I'm not sure we should impose such a huge code reformatting at all.