[melodic] Compatibility fix for OGRE 1.10.4 and up. #1503
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since OGRE v1.10.4, the signature of [`OgreMovableObject::getName`](https://github.com/OGRECave/ogre/blob/v1.10.4/OgreMain/include/OgreMovableObject.h#L204) is no longer a virtual function. To accommodate that, conditionally declare `getName()` for `rviz::MovableText`.
|
@rhaschke This is ready for review and merge. Thanks! |
|
Thanks for this fix, @seanyen. However, I applied it to the noetic-devel branch only, as only there we have guarantee compatibility with newer versions of Ogre (and we can use the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent lint fix causes a build break when building RViz with OGRE v1.10.4 and up.
This pull request is attempting to make the RViz to be compatible with OGRE 1.10.4 and up again. And here is some context:
Since OGRE v1.10.4, the signature of
OgreMovableObject::getNameis no longer a virtual function. To accommodate that, conditionally declare the matched signature ofgetName()forrviz::MovableText.