Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Displays panel content scrolls horizontally, hides unfold arrows #1545

Closed
felixvd opened this issue Sep 23, 2020 · 2 comments
Closed

Displays panel content scrolls horizontally, hides unfold arrows #1545

felixvd opened this issue Sep 23, 2020 · 2 comments

Comments

@felixvd
Copy link

felixvd commented Sep 23, 2020

The content in the Displays panel can move horizontally, so that the unfold arrow on the left is hidden, like in these screenshots:
(In the bottom one, I scrolled back to the left using the arrow keys)

screenshot1

screenshot2

In this MoveIt PR, a simple fix for a similar problem was proposed, which simply removes the AutoScroll property from the QtCreator .ui file. I would have submitted a PR, but I didn't find the corresponding location in the Rviz repository on first look.

Your environment

  • OS Version: Ubuntu 18.04
  • ROS Distro: Melodic
@rhaschke
Copy link
Contributor

Applying the "simple fix" from MoveIt in rviz's PropertyTreeWidget solves the scrolling issue. However, without scrolling editor widgets, e.g. the button of a combo box, will be hidden behind the scrollbar. Looks like this is a bug in Qt's TreeView, not correctly adapting the visible area when a scrollbar is displayed.
I can imagine two fixes:

  • Automatically scroll back as soon as the active editor is closed
  • Find a workaround to fix the Qt bug

The latter approach obviously will require more time. First of all, we should try to confirm that it is a Qt bug and report it upstream.

@felixvd
Copy link
Author

felixvd commented Oct 19, 2020

🎉

@rhaschke rhaschke mentioned this issue Nov 16, 2020
Merged
UniBwTAS pushed a commit to UniBwTAS/rviz that referenced this issue Jun 7, 2021
@rhaschke @AndreasR30
SplitterHandle: Consider scrollbar width
e18f769 
If there is a scrollbar visible, the visible width of the viewport is reduced,
which should be considered when computing the width of the second column.
Without this, the viewport will scroll horizontally to bring the 2nd column into view,
thus hiding the unfold arrows in the first column. Fixes ros-visualization#1545.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@felixvd @rhaschke