-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cross-platform CI with conda packages (minimal version) #1636
Add cross-platform CI with conda packages (minimal version) #1636
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for ignoring this PR for so long. I didn't have time to look into this yet.
Of course, I'm open to increase cross-platform compatibility and I agree to most of the changes here. However, I'm not sure we should establish a separate CI workflow. In MoveIt we experienced many false-positive alarms. So if you insist in this approach, please ensure that you fix all upstream dependencies to not experience false alarms.
src/rviz/default_plugin/interactive_markers/interactive_marker_control.h
Outdated
Show resolved
Hide resolved
Ok, that was definitely too early for me :) sorry. I should boot on Windows and see what's going on here. |
b47ab97
to
9e81c2c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more comments 😉
I just merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally, some remarks to the workflow definition. Please rename some files:
.github/ci_cross_platform_env.yml
->.github/robostack_env.yaml
.github/workflows/cross_platform_ci.yml
->.github/workflows/robostack.yaml
.github/workflows/prerelease.yml
->.github/workflows/prerelease.yaml
Fix as many versions as possible to reduce the risk of false-positives.
Co-authored-by: Robert Haschke <rhaschke@users.noreply.github.com>
Co-authored-by: Robert Haschke <rhaschke@users.noreply.github.com>
Description
This PR supersedes #1600 and introduces cross-platform CI for rviz using the RoboStack. It is a minimal set of changes, in particular it does not include changes from #1532 that should be discussed separately. It would be great to get some feedback from the rviz maintainers to see whether there is interest in getting this merged :)
/cc @wolfv
Checklist
YAML
orrosbag
file with aMarkerArray
msg.Due to the lack of active maintainers, we cannot provide support for older release branches anymore.