Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frame axes trail #1677

Merged
merged 3 commits into from
Nov 5, 2021
Merged

frame axes trail #1677

merged 3 commits into from
Nov 5, 2021

Conversation

christian-rauch
Copy link
Contributor

@christian-rauch christian-rauch commented Nov 2, 2021

Description

Add the option to add a trail (Ogre::RibbonTrail) to the frame axes display. This replicates the "Show Trail" features from the RobotModelDisplay. This implements and fixes #1627.

The ribbon trail will show the path a frame took. However, when the frame axes and ribbon trail is initialised, it will show a trail from the origin to where the frame is spawned. I am not sure if this intended behaviour that is also present in the RobotModelDisplay view.

Edi: I think the problem simply stems from the visualisation of the axes scene node which is rendered at the origin before the first frame pose has been received.

Checklist

  • If you are changing GUI, please include screenshots showing how things looked before and after.
  • Choose the proper target branch: latest release branch, for non-ABI-breaking changes, future release branch otherwise.

rviz_screenshot_2021_11_02-11_03_42

rviz_screenshot_2021_11_02-11_04_27

Copy link
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution!

@christian-rauch
Copy link
Contributor Author

Feel free to squash your fixes into my commit.

@rhaschke Do you have an idea how this "jump" from the origin to the first frame pose can be eliminated?

@rhaschke
Copy link
Contributor

rhaschke commented Nov 3, 2021

Do you have an idea how this "jump" from the origin to the first frame pose can be eliminated?

I think I resolved that issue already in 371d3bd. In which use case do you still observe it?

@christian-rauch
Copy link
Contributor Author

I think I resolved that issue already in 371d3bd. In which use case do you still observe it?

Yes. The frame itself is not shown before a pose is set. But once a pose is set, I still see a trail from the origin to that pose.

@rhaschke
Copy link
Contributor

rhaschke commented Nov 3, 2021

Not for me (origin is of course at the base of the robot):
image

@rhaschke rhaschke merged commit e40d99a into ros-visualization:noetic-devel Nov 5, 2021
@christian-rauch christian-rauch deleted the axes_trail branch November 5, 2021 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: show frame trails
2 participants