Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to rename saved views is gone in Hydro rviz. #679

Closed
hershwg opened this issue Sep 5, 2013 · 2 comments
Closed

Ability to rename saved views is gone in Hydro rviz. #679

hershwg opened this issue Sep 5, 2013 · 2 comments

Comments

@hershwg
Copy link
Member

hershwg commented Sep 5, 2013

This change c6dacb1 (make read-only properties appear disabled) breaks the ability to rename saved Views.

Open the "Views" panel, click "Save", then click on the newly-saved view entry which will be named after the current ViewController, often "Orbit".

First problem is that the entry has a gray text color, so looks bad.

The next problem is that the entry is not selectable, so there is no way to rename or remove it. In the old days (before c6dacb1), the saved view entries were selectable but read-only. They were drawn in black text and were remove-able and rename-able.

In my opinion the change c6dacb1 could just be reversed.

@dgossow
Copy link
Member

dgossow commented Sep 5, 2013

I'm ok with reverting

dgossow pushed a commit to dgossow/rviz that referenced this issue Sep 13, 2013
dgossow pushed a commit to dgossow/rviz that referenced this issue Sep 13, 2013
@dgossow dgossow mentioned this issue Sep 13, 2013
@dgossow
Copy link
Member

dgossow commented Sep 13, 2013

I actually fixed this a while ago on my local checkout. Merging #687 will fix this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants