Adjustable line width for Path display + offset property #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…which allows to set the line width of the paths.
…regard to the fixed frame origin
| for( size_t i = 0; i < manual_objects_.size(); i++ ) | ||
| { | ||
| Ogre::ManualObject* manual_object = manual_objects_[ i ]; | ||
| Ogre::ManualObject*& manual_object = manual_objects_[ i ]; |
There was a problem hiding this comment.
Can you explain why you made this particular change?
|
Other than the comment this looks good, and I tested it locally and it worked as described! One thing I ran into was that occasionally due to the nature of the billboards the paths would not render after flipping the camera around to look at them from the other side.The normal side would not flip to point at the camera until I zoomed really far in. I think this is just inherent in the billboards style point, so I don't think it needs to be addressed here. I think this is g2g. |
wjwwood
added a commit
that referenced
this pull request
Feb 7, 2015
…ions Adjustable line width for Path display + offset property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new display style called "Billboards" to the Path display, similar to how it is implemented for the Grid display. For the "Billboards" style, the line width can be adjusted, which implements enhancement request #650 and is helpful when e.g. displaying paths using a projector. The old display style "Lines" is preserved and left untouched for backwards compatibility.
I also added an "Offset" property to the Path display, that allows to shift the displayed path in relation to the origin of the fixed frame. Useful to e.g. shift the Z coordinate when displaying lots of information in Rviz that otherwise overlaps.