Updated the marker display to allow namespaces to be enabled/disabled from the config #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… based on the loaded config. Enabled state is stored for each namespace in a map, which is used to lookup the state whenever a namespace is added to the display.
|
lgtm I was able to reproduce this with the |
wjwwood
added a commit
that referenced
this pull request
Feb 26, 2016
Updated the marker display to allow namespaces to be enabled/disabled from the config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The marker display does not currently load the enabled/disabled state of namespaces from its config. Those values are simply not used. These changes load the enabled/disabled state of namespaces from the config into a map which gets used to disable namespaces when they are added.
This is essentially the same fix as commit 0baa9f3 but applied to the marker display instead of the tf display.