Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license and copyright #1097

Conversation

Ellon
Copy link
Contributor

@Ellon Ellon commented May 2, 2017

No description provided.

Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks!

@wjwwood wjwwood merged commit 5a47282 into ros-visualization:Ellon-feature/covariances__kinetic-devel May 2, 2017
wjwwood added a commit that referenced this pull request May 2, 2017
* Add display for PoseWithCovariance

The visual of the covariance is defined by CovarianceVisual class. The angular
part should be improved.

* Update OdometryDisplay to show covariances

* Add script to send messages that contain covariances

* [default_plugin] Refactor CovarianceVisual

- Use more Ogre Scene Nodes to position/rotate/scale shapes
- Use an 4 shapes for orientation: 3 ellipses for 3D posed and one cone for 2D poses
- Display flat objects when dealing with 2D poses (cov of z, roll, pitch <= 0.0)
- Make this visual constructble only from CovarianceProperty

* [properties][default_plugin] Refactor CovarianceProperty

- The property holds all the CovarianceVisual instances, and updates them then
  covariance properties change, without passing by the parent display.
- Moved it from properties to to default_plugin

* [default_plugin] Do not keep instances of CovarianceVisual on odometry display

Let CovarianceProperty handle how to exhibit a CovarianceVisual

* [default_plugin] Fix selection tool for PoseWithCovariance messages.

Also let CovarianceProperty handle the exhibition of CovarianceVisuals

* fix isnan compiler error

* whitespace

* Add license and copyright (#1097)
@Ellon Ellon deleted the covariances__kinetic-devel branch May 3, 2017 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants