Created a new Preferences window, and added PromptSaveOnExit option. #1106
Conversation
|
@mastereric sorry for the long delay in reviewing this. Looks like there are some merge conflicts now. One of us may look at resolving the conflicts soon, but if you have time that would be appreciated. |
|
@wjwwood The commit has been rebased to resolve conflicts with the base branch. One thing to note about the preferences window is that I added it with the intent of creating infrastructure to allow myself or other users to create additional options in the future. It only has one option because I only had one feature I wanted to add. |
|
@wjwwood It has been 17 days since this pull request was last reviewed. There are currently no conflicts, and if you see no problem with the changes I would like them merged. |
|
@mastereric one of us needs to compile it and try it out. We'll get to as soon as possible. Thanks for your patience. |
|
Hey @wjwwood, |
|
Hey @mastereric, you're right that this has taken a long time to get reviewed; we will try to look at it this week/next. One thing I'm able to say is now that, unfortunately, since the PR will break ABI, it is not likely we will be able to release this into existing distros, but instead will have to hold for the Melodic release even if it gets approved. I'll get back to you with a more thorough review once I've tested it out. |
|
rebasing your branch closed the PR accidentally. I opened #1216 in its place and will comment on that PR. |
For tutorials installed to a read-only location, it may be disorienting for the user to be prompted to save. For this reason, I created a preferences dialog window, with a boolean option for whether to Prompt Save on Exit, defaulting to true. These preferences are saved to any config .rviz files that are created.