rviz::MessageFilterDisplay has a hardcoded subscriber queue size #1035 #1113
Conversation
| @@ -0,0 +1,65 @@ | |||
| /* | |||
| * Copyright (c) 2012, Willow Garage, Inc. | |||
There was a problem hiding this comment.
It would be appropriate, @dkaznacheev, to add your own copyright here.
|
Thanks for the pull request. I'll get to reviewing and merging it asap. |
There was a problem hiding this comment.
thanks @dkaznacheev for the PR. In general it looks good, there are just some style changes requested and a question about the need to unsubscribe/resubscribe
| virtual void updateQueueSize() | ||
| { | ||
| tf_filter_->setQueueSize( (uint32_t) queue_size_property_->getInt() ); | ||
| unsubscribe(); |
There was a problem hiding this comment.
did you add the unsubscribe and resubscribe calls because you found that they were necessary? most places (e.g. marker display) just call setQueueSize and nothing else, but that might be what's beneath issue #1135.
Apparently keeping "Willow Garage, Inc" (ros-visualization#1142) was not the right thing (ros-visualization#1113).
|
@dkaznacheev did you have any time to follow up on the requested changes so this feature can get merged for other users? |
|
Replaced with #1428. |
…tion#1113) (ros-visualization#1129) Signed-off-by: Yadunund <yadunund@openrobotics.org> (cherry picked from commit 68d9167758b651d2e4c01f4aeb74a9613110e751) Co-authored-by: Yadu <yadunund@openrobotics.org>
MessageFilterDisplaybase class had a hardcoded queue size formessage_filters::Subscriberandtf::MessageFilterfields, so I created a separate IntProperty inMessageFilterDisplayfor this purpose.I am also interested if it's possible to make it an adjustable parameter in rviz global options; if so, I could try to fix it.