Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix moc error with Qt 4.8.7 and Boost 1.58 in xenial #1149

Merged
merged 1 commit into from
Sep 27, 2017

Conversation

meyerj
Copy link
Contributor

@meyerj meyerj commented Sep 18, 2017

I needed this patch to compile the indigo-devel branch (or the latest released version 1.11.18) successfully in Ubuntu Xenial with Boost 1.58 and Qt 4.8.7 for a custom build of ros-indigo-desktop-full from source:

Generating moc_robot.cpp
usr/include/boost/type_traits/detail/has_binary_operator.hp:50: Parse error at "BOOST_JOIN"
AUTOGEN: error: process for /home/jenkins/workspace/ros-indigo-xenial/rviz/obj-x86_64-linux-gnu/src/rviz/moc_robot.cpp failed:
usr/include/boost/type_traits/detail/has_binary_operator.hp:50: Parse error at "BOOST_JOIN"

Generating moc_robot_joint.cpp
usr/include/boost/type_traits/detail/has_binary_operator.hp:50: Parse error at "BOOST_JOIN"
AUTOGEN: error: process for /home/jenkins/workspace/ros-indigo-xenial/rviz/obj-x86_64-linux-gnu/src/rviz/moc_robot_joint.cpp failed:
usr/include/boost/type_traits/detail/has_binary_operator.hp:50: Parse error at "BOOST_JOIN"

Generating moc_robot_link.cpp
usr/include/boost/type_traits/detail/has_binary_operator.hp:50: Parse error at "BOOST_JOIN"
AUTOGEN: error: process for /home/jenkins/workspace/ros-indigo-xenial/rviz/obj-x86_64-linux-gnu/src/rviz/moc_robot_link.cpp failed:
usr/include/boost/type_traits/detail/has_binary_operator.hp:50: Parse error at "BOOST_JOIN"
$ dpkg -l libqt4-dev libboost1.58-dev
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name                   Version                Architecture Description
+++-======================-======================-============-=====================================
ii  libboost1.58-dev:amd64 1.58.0+dfsg-5ubuntu3.1 amd64        Boost C++ Libraries development files
ii  libqt4-dev             4:4.8.7+dfsg-5ubuntu2  amd64        Qt 4 development files

Copy link
Contributor

@dhood dhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch; this matches what is recommended in https://bugreports.qt.io/browse/QTBUG-22829 as a workaround for qt4 + boost 1.58. While this isn't a targeted combination, others are interested in it (#1153) and this is simple enough to merge, so +1

@dhood dhood merged commit e4d1dde into ros-visualization:indigo-devel Sep 27, 2017
@meyerj meyerj deleted the fix-moc-boost-1.58 branch September 27, 2017 19:39
130s pushed a commit to 130s/rviz that referenced this pull request Aug 21, 2024
…tion#1149)

Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
(cherry picked from commit 82385de6ef21db8b4dde57e397f039803c0b102e)

Co-authored-by: Alejandro Hernández Cordero <alejandro@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants