Fix compatibility with boost 1.69. #1320
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old signals library has been removed from boost 1.69. Because of that, find_package(Boost COMPONENTS signals ...) doesn't work anymore. The newer signals2 library is header only and does not need to be listed as boost component at all.
|
Replaced by #1344. I think support for tf1 < 1.11.3, which is ~5 years old, can be dropped. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old signals library has been removed from boost 1.69. Because of that,
find_package(Boost COMPONENTS signals ...)doesn't work anymore. The newer signals2 library is header only and does not need to be listed as boost component at all.Since
rvizseems to still want to be compatible with the oldsignalslibrary, this PR makes the inclusion ofsignalsas boost component optional, depending on whethersignalsorsignals2will be used.