Fix marker handling #1400
Merged
Fix marker handling #1400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ogre::Real might be float or double. Both types have different ranges.
This was referenced Aug 12, 2019
|
Could you backport the other changes as well? E.g. setting the scale before checking the transform. This allows alternative uses of the function to make use of the scale even if the transform is not valid. Also I would encourage to initialise all values in general in RViz. It helps to debug issues, e.g. by having zeros instead of random values. |
|
I intentionally didn't port these changes because they are unnecessary overhead as discussed in #1396 (review). |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix segfaults due to invalid marker messages.