Frame-Aligned View Controller #1405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhaschke
force-pushed
the
tf-aligned-view
branch
from
49e8eab to
9d9a429
Compare
|
@mcevoyandy, could you please review? Does this PR implement the desired functionality? |
rhaschke
force-pushed
the
tf-aligned-view
branch
from
9d9a429 to
85b5bb2
Compare
mcevoyandy
approved these changes
Aug 28, 2019
There was a problem hiding this comment.
@rhaschke this provides the functionality I was looking for. Thanks for considering the addition.
... and allow locking of camera pose Derive from FramePositionTrackingViewController to avoid limitations of FPSViewController (no roll angle, busy camera updates)
rhaschke
force-pushed
the
tf-aligned-view
branch
from
85b5bb2 to
9adb38b
Compare
rhaschke
added a commit
that referenced
this pull request
Aug 29, 2019
rhaschke
added a commit
that referenced
this pull request
Aug 31, 2019
Closed
|
@rhaschke could we backport this feature to Kinetic? @mcevoyandy developed this for a client still on 16.04 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative, much simpler implementation of #1403 drawing on the existing FPS view controller. If required, we could add a
BoolPropertyto lock the camera, i.e. disable mouse interaction as in #1403.