Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly free allocated memory #1406

Merged
merged 1 commit into from
Aug 28, 2019

Conversation

artivis
Copy link
Contributor

@artivis artivis commented Aug 27, 2019

Description

Memory allocated by make*Palette() was not freed by anyone.
It is now allocated with Ogre's OGRE_ALLOC_T to be freed directly by MemoryDataStream.

Fix #1391

  Memory allocated by 'make*Palette' was not freed by anyone.
  It is now allocated/freed by Ogre ALLOC & MemoryDataStream

  Fix ros-visualization#1391
Copy link
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot!

@rhaschke rhaschke merged commit 9647c75 into ros-visualization:melodic-devel Aug 28, 2019
rhaschke pushed a commit that referenced this pull request Aug 28, 2019
Memory allocated by 'make*Palette' was not freed by anyone.
It is now allocated / freed by Ogre ALLOC and MemoryDataStream respectively.
@rhaschke rhaschke mentioned this pull request Sep 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

coverity report - resource leak
2 participants