Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LineStripMarker: ignore invalid points #1440

Merged
merged 1 commit into from
Oct 27, 2019

Conversation

rhaschke
Copy link
Contributor

Fix #1439.

@rhaschke
Copy link
Contributor Author

@wjwwood: What is your opinion about including such validFloats() checks in rviz?
Obviously, you didn't include them in the past - maybe for performance reasons, expecting the data publishers to provide proper messages.
On the other hand, I would argue, that such wrong messages shouldn't crash rviz.

@simonschmeisser
Copy link
Contributor

In my opinion it should not be possible to crash rviz with external data! Ever! Well at least not easily ;)

@rhaschke
Copy link
Contributor Author

@simonschmeisser, thanks for reviewing.

@rhaschke rhaschke merged commit 5805917 into ros-visualization:melodic-devel Oct 27, 2019
@wjwwood
Copy link
Member

wjwwood commented Oct 30, 2019

Sorry for the late reply.

Obviously, you didn't include them in the past - maybe for performance reasons, expecting the data publishers to provide proper messages.

Though I can imagine it might be a performance issue, the safety is probably be worthwhile. I didn't write this code originally though, so I cannot say one way or the other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rviz crashes when visualization marker contains nan in values
3 participants