Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix yaml-cpp not found on macOS (catalina) #1445

Merged
merged 3 commits into from
Nov 21, 2019
Merged

fix yaml-cpp not found on macOS (catalina) #1445

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0779b87
fix yaml-cpp on macOS (catalina)
ahoarau Nov 20, 2019
a664541
use find_package instead of pkg-config
ahoarau Nov 21, 2019
6e26c22
fix variable name
ahoarau Nov 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/rviz/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
pkg_check_modules(YAMLCPP REQUIRED yaml-cpp>=0.5)
if(APPLE)
find_package(yaml-cpp REQUIRED)
else()
pkg_check_modules(YAMLCPP REQUIRED yaml-cpp>=0.5)
endif()

if(UNIX AND NOT APPLE)
find_package(X11 REQUIRED)
Expand Down Expand Up @@ -145,6 +149,7 @@ target_link_libraries(${PROJECT_NAME}
${X11_X11_LIB}
${ASSIMP_LIBRARIES}
${YAMLCPP_LIBRARIES}
${yaml-cpp_LIBRARIES}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable is named YAML_CPP_LIBRARIES on Ubuntu 18.04. Is it different on Mac?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake. fixed !

)


Expand Down