OgreUTFString was moved in 1.12 #1645
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wouldn't it make more sense to use the fix proposed in #1670? |
|
Why exactly? |
|
According to your description in the PR adding |
|
Well, @rhaschke changed that only recently, this is basically a partial revert. Those includes without the |
|
I prefer #1670 of this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
41d62f5 breaks compilation on ogre 1.12.x as
OgreUTFString.hhas been moved toOGRE/Overlay/OgreUTFString.hhere OGRECave/ogre@a9ab158later with the upcoming ogre 1.13 this header is completely gone here
OGRECave/ogre@3d7d116#diff-0776b468d71baadd36bc4b898e6b2e11ea4b3e117bdf5fbcd8eda3065f3bfb36
will need another (more involved I fear) fixup then