Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several improvements to TF display #1789

Merged
merged 4 commits into from
Mar 29, 2023
Merged

Several improvements to TF display #1789

merged 4 commits into from
Mar 29, 2023

Conversation

rhaschke
Copy link
Contributor

This improves the TF display in multiple ways:

  • Insert all known frames to the tree (before only ones that were connected to rviz' global frame).
    This allows spotting disconnected trees in a glance.
  • Ensure that frames are inserted in sorted fashion.
  • Improve insertion and re-parenting of tree nodes

rhaschke added 4 commits March 29, 2023 10:14
@rhaschke
Create tree nodes also if the frame is not connected to rviz' global …
b9f72e2 
…frame
@rhaschke
Insert frame properties sorted
a21ff8a 
Sorting frame names before insertion just ensures that frames are inserted
initially in sorted fashion. To also insert frames showing up later in a
sorted fashion, we need to explicitly insert them sorted.
@rhaschke
Don't postpone insertion of frames into tree
9ba642a
@rhaschke
Reparent children to root tree node when deleting a frame
0d19929
@rhaschke rhaschke mentioned this pull request Mar 29, 2023
Merged
@rhaschke rhaschke merged commit 1bb573f into ros-visualization:melodic-devel Mar 29, 2023
@rhaschke rhaschke deleted the tf-display branch March 29, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rhaschke