-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Add pose covariance displays #974
Conversation
The visual of the covariance is defined by CovarianceVisual class. The angular part should be improved.
Thanks for the pr. As I mentioned here: laas/rviz_plugin_covariance#11 I'd like to see the plugin merged and fixed up over there first. If people agree it is working well then I'll consider it for integration into rviz. |
+1 for getting this into rviz. I guess there cannot be too many serious users out there that we would "leave behind". And it is not too hard to switch your rviz config to use the new plugin from rviz proper. We could add deprecation warning to the plugin in the extra repo, informing users about a more up-to-date version in rviz. In particular before the latest PR was merged in the plugin repository, the reference frames in which the covariances were displayed were wrong. Therefore that was a breaking change in any case (either fixing previously wrong displays, or breaking workarounds for the previously wrong displays). |
- Use more Ogre Scene Nodes to position/rotate/scale shapes - Use an 4 shapes for orientation: 3 ellipses for 3D posed and one cone for 2D poses - Display flat objects when dealing with 2D poses (cov of z, roll, pitch <= 0.0) - Make this visual constructble only from CovarianceProperty
- The property holds all the CovarianceVisual instances, and updates them then covariance properties change, without passing by the parent display. - Moved it from properties to to default_plugin
…y display Let CovarianceProperty handle how to exhibit a CovarianceVisual
Also let CovarianceProperty handle the exhibition of CovarianceVisuals
+1 for this. |
👍 I have been using it for a month and works fine |
Hi @Ellon, did you consider remake this PR for Kinetic? |
HI @corot, no I didn't considered it. In my developments here I'm using Indigo, and I don't have time now to this remake right now. Maybe soon in the future. But feel free to propose a remake if you have time to do so! |
Closing in favor of #1096 |
Hi all,
This PR addresses #381 .
I've been working on visualizing properly the covariances on rviz, improving what was done on rviz_plugin_covariance. I decided to integrate it already on rviz so other people could discuss the enhancements here.
Summary of features:
Future features:
More information can be found in the discussions here and here.