Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding convince toolchain to docker and a small example to technologies. #44

Merged
merged 24 commits into from
Sep 23, 2024

Conversation

ct2034
Copy link
Contributor

@ct2034 ct2034 commented Sep 21, 2024

Could you please test if this works on your side, too? Thanks :)

It needed a little hack because one of our dependencies is not happy with python 3.12 (convince-project/AS2FM#7). But before the workshop, we will probably replace it anyway.

Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
Copy link
Collaborator

@sea-bass sea-bass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example worked fine for me, just some minor tweaks to the README that are all optional.

Also, when running the scxml_to_jani main.xml I get some deprecation commands:

Warning: SCXML topic publisher: the 'topic' argument is deprecated. Use 'name' instead.

Is this something we can change to remove the warnings?


Requesting changes for 2 reasons:

  1. Because there are a few submodules that are being accidentally updated -- you can simply resolve this by going into the respective folders and doing a git checkout <commit_sha> with whatever the latest on main are.
  2. There is probably no need for us to install both wget and curl since they do the same thing

.docker/Dockerfile Outdated Show resolved Hide resolved
.docker/Dockerfile Show resolved Hide resolved
dependencies/SkiROS2/skiros2_std_lib Outdated Show resolved Hide resolved
dependencies/pyrobosim Outdated Show resolved Hide resolved
technologies/README.md Outdated Show resolved Hide resolved
technologies/convince/README.md Outdated Show resolved Hide resolved
technologies/convince/README.md Show resolved Hide resolved
technologies/convince/README.md Outdated Show resolved Hide resolved
technologies/convince/README.md Outdated Show resolved Hide resolved
technologies/convince/README.md Outdated Show resolved Hide resolved
@sea-bass
Copy link
Collaborator

sea-bass commented Sep 21, 2024

Oh one more thing, I somehow got myself into a rosdep issue because the CONVINCE bt_tools depends on behaviortree_cpp_v3 which is not officially listed as a Jazzy package: https://index.ros.org/search/?term=behaviortree_cpp_V3

Not sure how it built in the first place (I might have done something bad with the Docker cache), but I would still suggest replacing that dependency with the latest version, behaviortree_cpp, if possible.

ct2034 and others added 8 commits September 22, 2024 20:13
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
Co-authored-by: Sebastian Castro <4603398+sea-bass@users.noreply.github.com>
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
sea-bass
sea-bass previously approved these changes Sep 23, 2024
.docker/Dockerfile Outdated Show resolved Hide resolved
@sea-bass sea-bass dismissed their stale review September 23, 2024 12:16

Submodules still not resolved

@ct2034 ct2034 merged commit f335fe8 into main Sep 23, 2024
3 checks passed
@ct2034 ct2034 deleted the adding-convince branch September 23, 2024 15:39
ct2034 added a commit that referenced this pull request Oct 7, 2024
…es. (#44)

* adding as2fm as submodule
* adding bt_tools
* technology readme
* convince example
---------
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
Co-authored-by: Sebastian Castro <4603398+sea-bass@users.noreply.github.com>
Co-authored-by: Sebastian Castro <sebas.a.castro@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants