-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding convince toolchain to docker and a small example to technologies. #44
Conversation
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example worked fine for me, just some minor tweaks to the README that are all optional.
Also, when running the scxml_to_jani main.xml
I get some deprecation commands:
Warning: SCXML topic publisher: the 'topic' argument is deprecated. Use 'name' instead.
Is this something we can change to remove the warnings?
Requesting changes for 2 reasons:
- Because there are a few submodules that are being accidentally updated -- you can simply resolve this by going into the respective folders and doing a
git checkout <commit_sha>
with whatever the latest on main are. - There is probably no need for us to install both
wget
andcurl
since they do the same thing
Oh one more thing, I somehow got myself into a Not sure how it built in the first place (I might have done something bad with the Docker cache), but I would still suggest replacing that dependency with the latest version, |
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
Co-authored-by: Sebastian Castro <4603398+sea-bass@users.noreply.github.com>
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
…es. (#44) * adding as2fm as submodule * adding bt_tools * technology readme * convince example --------- Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com> Co-authored-by: Sebastian Castro <4603398+sea-bass@users.noreply.github.com> Co-authored-by: Sebastian Castro <sebas.a.castro@gmail.com>
Could you please test if this works on your side, too? Thanks :)
It needed a little hack because one of our dependencies is not happy with python 3.12 (convince-project/AS2FM#7). But before the workshop, we will probably replace it anyway.