Skip to content

Commit

Permalink
bump CMake minimum version to use new behavior of CMP0048 (#1052)
Browse files Browse the repository at this point in the history
* Use CMP0048 New behavior

CMP0048 NEW behavior sets PROJECT_VERSION variables to empty strings if
project() is called with no VERSION argument. This could be a problem
for packages that set VERSION variables prior to project() because
project() would then clear them, but catkin does not do this.

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>

* try raising the minimum CMake version instead

Co-authored-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
  • Loading branch information
sloretz and dirk-thomas committed Jan 22, 2020
1 parent 4826a8a commit 252bc84
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 2.8.3)
cmake_minimum_required(VERSION 3.0.2)

set(catkin_EXTRAS_DIR ${CMAKE_CURRENT_SOURCE_DIR}/cmake)

Expand Down

0 comments on commit 252bc84

Please sign in to comment.