[Windows] Accommodate different drives for --root #1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dirk-thomas This is ready for review and merge. Thanks for your feedback on the drive name thing. Problem do manifest when the source workspace is on different drives from the install space. |
|
Thanks for the patch. That was exactly what I was concerned about in the previous patch: #1070 (comment) |
dirk-thomas
changed the title
dirk-thomas
pushed a commit
that referenced
this pull request
Mar 19, 2020
* accommodate different drives. * revert extra changes.
|
Cherry-picked to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up fix for #1070
In cases of that
CMAKE_INSTALL_PREFIXresides in the different drive from the source code, the previous fix will result in thePythonmodule to be installed at the same drive where the source code sits. For example, if ROS source code is checked out onC:drive andcmakeinstall intoD:\opt\instsall, thePythonmodule will be mistakenly installed toc:\opt\install\.This pull request is to take the target drive into consideration. And hope this can be cherry-picked into
kinectic-devel.