Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] stop setuptools egg packaging. #1070

Merged
merged 2 commits into from
Mar 17, 2020

Conversation

seanyen
Copy link
Contributor

@seanyen seanyen commented Mar 14, 2020

This is the same treatment as #1068 but for Windows build.

This would need to be cherry-picked to kinect-devel too.

@seanyen
Copy link
Contributor Author

seanyen commented Mar 14, 2020

@dirk-thomas This is ready for review and merge. Thanks.

@seanyen
Copy link
Contributor Author

seanyen commented Mar 17, 2020

@dirk-thomas Friendly ping.

@dirk-thomas
Copy link
Member

If it works for me that is good enough for me 😉 Thanks for the patch.

@dirk-thomas dirk-thomas merged commit 5723296 into ros:noetic-devel Mar 17, 2020
dirk-thomas pushed a commit that referenced this pull request Mar 17, 2020
* stop setuptools egg packaging.

* updated for consistency.
@dirk-thomas
Copy link
Member

Cherry-picked to kinetic-devel: c675913.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants