catkin_make* should allow for MAKEFLAGS
#402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Ok, now @dirk-thomas for review. I accidentally messed up pull request #400. |
|
The graph lacks an arrow from "Does MAKEFLAGS have any job flags in it?" to "Is ROS_PARALLEL_JOBS set?" in case of "No". |
|
+1 |
|
@dirk-thomas updated, review and merge please |
dirk-thomas
added a commit
that referenced
this pull request
Mar 28, 2013
catkin_make* should allow for `MAKEFLAGS`
cwecht
pushed a commit
to cwecht/catkin
that referenced
this pull request
Mar 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
caktin_make*programs always give job arguments tomake, even if none are passed to them directly, e.g.catkin_make->make -j8 -l8andcatkin_make -j1->make -j1 -l1.This prevents the Make environment variable
MAKEFLAGSfrom working withcatkin_make*. I propose a new logic for handling-j,--jobs,-l,--load-averagearguments:This will allow users to override the make job options with direct arguments to
catkin_make*,MAKEFLAGS, orROS_PARALLEL_JOBS.EDIT: Removed references to
CATKIN_PARALLEL_JOBSbecause it is overshadowed byMAKEFLAGSand direct arguments, and I did not want it to have the same weird specification asROS_PARALLEL_JOBSwhere it has flags for make not just a number.