Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catkin_make* should allow for MAKEFLAGS #400

Closed
wants to merge 1 commit into from
Closed

Conversation

wjwwood
Copy link
Member

@wjwwood wjwwood commented Mar 27, 2013

Currently caktin_make* programs always give job arguments to make, even if none are passed to them directly, e.g. catkin_make -> make -j8 -l8 and catkin_make -j1 -> make -j1 -l1.

This prevents the Make environment variable MAKEFLAGS from working with catkin_make*. I propose a new logic for handling -j, --jobs, -l, --load-average arguments:

catkin_make_jobs

This will allow users to override the make job options with direct arguments to catkin_make*, MAKEFLAGS, or ROS_PARALLEL_JOBS.

EDIT: Removed references to CATKIN_PARALLEL_JOBS because it is overshadowed by MAKEFLAGS and direct arguments, and I did not want it to have the same weird specification as ROS_PARALLEL_JOBS where it has flags for make not just a number.

@ghost ghost assigned wjwwood Mar 26, 2013
@wjwwood
Copy link
Member Author

wjwwood commented Mar 27, 2013

@dirk-thomas for review

@wjwwood
Copy link
Member Author

wjwwood commented Mar 27, 2013

Scratch that I screwed it up...

@wjwwood
Copy link
Member Author

wjwwood commented Mar 27, 2013

See: #402

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant