Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

catkin_EXPORTED_TARGETS should always contain a (dummy) target #453

Closed
dirk-thomas opened this issue Jul 1, 2013 · 0 comments
Closed

catkin_EXPORTED_TARGETS should always contain a (dummy) target #453

dirk-thomas opened this issue Jul 1, 2013 · 0 comments
Assignees
@dirk-thomas
Labels
enhancement

Comments

@dirk-thomas
Copy link
Member

Based on the feedback on the mailing list the variable catkin_EXPORTED_TARGETS should always contain at least a (dummy) target. That would allow to use it with add_dependencies() without requiring to verify that the variable is not empty.

Imo this is overshooting and instead user land code should perform the correct check before using the variable (as it has to do it with any other variable used with that function).
@ghost ghost assigned dirk-thomas Jul 1, 2013
cwecht pushed a commit to cwecht/catkin that referenced this issue Mar 20, 2018
@wohe
Crash fix when "extrapolating". (ros#453)
4bad3c4 
It can happen that ros::Time::now() is slightly behind the latest pose
timestamp if sensor data had newer timestamps. We would crash before.
Instead, we now publish the latest pose which is even newer that what
we tried to publish before.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dirk-thomas dirk-thomas

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dirk-thomas