Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catkin_prepare_release should warn and not push if there are local changes #471

Closed
tfoote opened this issue Jul 12, 2013 · 4 comments
Closed
Assignees

Comments

@tfoote
Copy link
Member

tfoote commented Jul 12, 2013

I know of several times when people run the changelog scripts then catkin_prepare_release which changes the package.xmls and commits them and creates tags, but doesn't touch the uncommitted changelogs.

It would be really great if it would error if there are local changes, possibly even untracked files. And have an option to override that check if you are doing something odd intentionally.

@dirk-thomas
Copy link
Member

It should error out if there are local modifications to changelog files and/or package.xml files.

It should warn if other files have modifications or if there are untracked files.

@dirk-thomas
Copy link
Member

@tfoote @wjwwood Please try the latest version of catkin_prepare_release. If there are no issues or feedback I would like to release catkin to use the weekend for the rebuild cycle.

@wjwwood
Copy link
Member

wjwwood commented Jul 13, 2013

The last quote in this line is still blue:

Bump version of all packages from '0.1.3' to '0.1.4'
                                                   ^ put a `@|` here

@wjwwood
Copy link
Member

wjwwood commented Jul 13, 2013

It's not exactly how I would format the output, but this looks fine to me.

At some point we should come up with some output formatting and color theme guidelines, so that all the tools can be consistent looking.

cwecht pushed a commit to cwecht/catkin that referenced this issue Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants