Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bin/* to the scripts in setup.py #555

Closed
vrabaud opened this issue Dec 2, 2013 · 2 comments
Closed

add bin/* to the scripts in setup.py #555

vrabaud opened this issue Dec 2, 2013 · 2 comments

Comments

@vrabaud
Copy link
Member

vrabaud commented Dec 2, 2013

Just not sure whether it was a decision to not include those (if not, that means they do not belong to the pip install then ?)

@dirk-thomas
Copy link
Member

Until now all scripts under bin are being handled by https://github.com/ros/catkin/blob/groovy-devel/bin/CMakeLists.txt.

Changing the scripts to be installed via the setup.py file is simple but only makes sense when the package can be pip-installed. But I am pretty sure that would not be the only files missing from a pip-based installation. I don't think that a pip-based installation is actually feasible (without significant extra effort).

@vrabaud
Copy link
Member Author

vrabaud commented Dec 4, 2013

Right, all the cmake folders would have to be copied too in some place understandable by CMAKE_PREFIX_PATH. Somehow I thought catkin was still pip-installable. Closing then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants