improve unicode handling #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. |
|
LGTM!! |
|
+1 |
cwecht
pushed a commit
to cwecht/catkin
that referenced
this pull request
Mar 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow up to #578 and #595 I have another patch to improve unicode handling.
Added another unit test which check processing when output is encoded.
@josegaert @nicolasWDC @saljam @wjwwood @yukota Since you have all been part of the previous discussion I would like to ask you to try the changes of this branch with your specific scenario.
Since these unicode issues are highly specific to your environment, available locale and output of your tools the more people will validate that it works the more confident we can be that it does not break things (as it has happened before). Please comment on this ticket with either feedback ("it works for you" as well as "it doesn't (please with as much details as possible)").