Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create thread-safe storage of source-space paths #674

Closed
jbohren opened this issue Jul 2, 2014 · 4 comments
Closed

Create thread-safe storage of source-space paths #674

jbohren opened this issue Jul 2, 2014 · 4 comments

Comments

@jbohren
Copy link
Member

jbohren commented Jul 2, 2014

Currently, as described in #670, when multiple catkin cmake processes are running with a merged develspace, they each want to modify devel/.catkin in order to store the sourcespace paths for each package. This information is used to build PATH-like variables like $ROS_PACKAGE_PATH.

If a parallel-safety flag is set, as proposed in #675, then we could generate this file with a top-level tool like catkin build.

@dirk-thomas
Copy link
Member

Please consider to provide a pull request for this.

@dirk-thomas
Copy link
Member

I assume catkin_tools addresses the need in its own way and this ticket can be closed?

@jbohren
Copy link
Member Author

jbohren commented Mar 20, 2015

I assume catkin_tools addresses the need in its own way and this ticket can be closed?

No, catkin_tools doesn't address this.

@dirk-thomas
Copy link
Member

dirk-thomas commented Jan 22, 2018

I will close this issue for now since it is unlikely that anyony is working on this in the future and it is unclear how this could be addressed in catkin itself.

Imo the build tool should avoid performing tasks in parallel which access the same files, e.g. by passing CATKIN_BUILD_BINARY_PACKAGE and generating these files itself.

cwecht pushed a commit to cwecht/catkin that referenced this issue Mar 20, 2018
@dirk-thomas dirk-thomas removed this from the untargeted milestone Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants