add --use-ninja option to catkin_make(_isolated) to use ninja instead of make #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 there are two or three repeated if clauses for the makefile name and command line args, but at two instances the function method will not save lines, but if there's ever to be more, it might make sense to make them a function. |
| @@ -133,11 +133,20 @@ def main(): | |||
| print(fmt('@{yf}Packages @{boldon}"%s"@{boldoff} not found in the workspace - ignoring them' % ', '.join(sorted(unknown_packages))), file=sys.stderr) | |||
| args.pkg = [name for name in args.pkg if name in packages_by_name] | |||
|
|
|||
| if '-G' not in cmake_args: | |||
There was a problem hiding this comment.
Is it valid for an input to be ['-GFoo'], which would cause this to fail? It seems to be possible:
% cmake -GXcode ..
-- The C compiler identification is AppleClang 6.0.0.6000054
-- The CXX compiler identification is AppleClang 6.0.0.6000054
-- Check for working C compiler using: Xcode
-- Check for working C compiler using: Xcode -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler using: Xcode
^C
Would it not be an error if you specify both a -G argument in the cmake_args and --use-ninja?
There was a problem hiding this comment.
Both good points. Addressed in second commit.
|
+1 |
|
Squashed. |
dirk-thomas
added a commit
that referenced
this pull request
Oct 23, 2014
add --use-ninja option to catkin_make(_isolated) to use ninja instead of make
cwecht
pushed a commit
to cwecht/catkin
that referenced
this pull request
Mar 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tfoote @wjwwood Please review.