sync up with gbp stuff #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: .gitignore
Conflicts: cmake/all.cmake cmake/debian-util.cmake cmake/setup.sh.in
|
marking invalid. |
dirk-thomas
pushed a commit
that referenced
this pull request
Jan 28, 2019
* Create env.bat and setup.bat in build_cmake_package for Windows (#9) * Skip the drive letter if run on Windows (#10) * Skip the drive letter if run on Windows * Remove unnecessary check for win32 * Provide top level devel space environment and setup bat files for Windows (#11) * use os.pathsep to join path components * revert whitespace change * Fix path backslashes in catkin_package.cmake (#25) * Update catkin_package.cmake * Update catkin_package.cmake * Update builder.py * Normalize the path from subs['cmake_prefix_path'] * Revert the unrelated changes from my bad merge in the previous commit. Revert the unrelated changes from my bad merge in the previous commit to keep this PR clean. * use underscope to exclude drive letter, and clarify there's no effect on Linux (#31) * Define string templates in separate steps and update comment (#32) * Create env.bat and setup.bat in build_cmake_package for Windows (#9) * define string templates in a separate step * change script writer function names * fix indentation for script template * fix env script name typo (#33) * minor nitpicks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still a work in progress. I have a few fixes related to python 2.6 version.
Also a bit of cmake for making a dist tarball and gbp. Expect gbp stuffs to change a lot as i figure out the work flow.