Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update download script to resume downloads when server supports it (fix #559) #575

Merged
merged 1 commit into from
Jan 7, 2014

Conversation

dirk-thomas
Copy link
Member

@tfoote @wjwwood Please review.

if not accept_ranges:
raise IOError('Server does not accept ranges to resume download')


def download_md5(uri, dest):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole second code branch could be avoided by using the above code block. The fetch of the md5sum file hopefully won't ever trigger a partial redownload, but the API is the same and this name poor anyway as it's not md5 specific at all.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not touched by the pull request. Simply because I did not want to change existing API.

But what avoidable "second code branch" are you referring to?

@bricerebsamen
Copy link

I tested it with my server that was making problems and it's working now...
For reference, here is the file that I use for testing:
http://cs.stanford.edu/group/driving/data/ladybug/ladybug_intrinsics.dat
it's likely to stay at this location for a long time, so feel free to use it in the future if you need to make changes.

@wjwwood
Copy link
Member

wjwwood commented Jan 7, 2014

+1

dirk-thomas added a commit that referenced this pull request Jan 7, 2014
update download script to resume downloads when server supports it (fix #559)
@dirk-thomas dirk-thomas merged commit 618d867 into groovy-devel Jan 7, 2014
@dirk-thomas dirk-thomas deleted the resume_downloads branch January 7, 2014 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants