remove CATKIN_TEST_RESULTS_DIR environment variable

[dirk-thomas]

This patch removes the CATKIN_TEST_RESULTS_DIR environment variable. That should prevent any kind of "cross talk" between packages build in parallel since the location is only depending on configure-time information.

The user can still override the location by setting the CMake variable via -DCATKIN_TEST_RESULTS_DIR=....

Addresses #719.

@esteve @tfoote @wjwwood Please review.

[tfoote]

lgtm

[esteve]

+1

[bricerebsamen]

that fixed #719 for me.

It prints a lot of lines about skipping packages such as the one below, but it finally reports the correct number of tests, success, etc.

Skipping "src/driving_public/carviz_plugins_imagery/plugin_description.xml": 'tests'

[wjwwood]

lgtm, however, I am concerned about how we roll this out since it is a pretty serious change to remove an env variable like this at such a low level in the system. I talked with @dirk-thomas about it and we agreed that the right thing to do was to go forward with it, but to be proactive about communicating this to the users and giving them a chance to comment before releasing this change.

[dirk-thomas]

@bricerebsamen The script searches recursively for .xml - by default starting in the current folder. You might want to pass the test results folder to narrow the search and prevent non-unit test results to show. For a non-isolated build with default paths that would be:

catkin_test_results build/test_results

Update: The script can not use an environment variable from the devel space for the exact location since the devel space is commonly not sourced when running tests. Also the naming scheme of the workspace can be custom and the script can not infer the correct location of the build space.

[mikepurvis]

Change LGTM. None of our tooling relies on setting CATKIN_TEST_RESULTS_DIR.

[aleeper]

+1.

[dirk-thomas]

Waiting for feedback after announcement: https://groups.google.com/forum/#!topic/ros-sig-buildsystem/suBvWzoGODU

[floweisshardt]

+1. None of our tooling uses 'CATKIN_TEST_RESULTS_DIR'.