Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only clean the test results of the current project #738

Merged
merged 2 commits into from
May 22, 2015

Conversation

dirk-thomas
Copy link
Member

Addresses #737.

@esteve @tfoote @wjwwood Please review.

@esteve
Copy link
Member

esteve commented May 22, 2015

+1

1 similar comment
@tfoote
Copy link
Member

tfoote commented May 22, 2015

+1

@dirk-thomas
Copy link
Member Author

I always thought that wiping the whole directory might be dangerous. Therefore I updated the clean commands to only remove files ending with .xml. So if someone passes in a "bad" test results dir it only wipes xml files and not everything.

@tfoote
Copy link
Member

tfoote commented May 22, 2015

+1 that's safer

@wjwwood
Copy link
Member

wjwwood commented May 22, 2015

+1

@esteve
Copy link
Member

esteve commented May 22, 2015

+1 again

dirk-thomas added a commit that referenced this pull request May 22, 2015
only clean the test results of the current project
@dirk-thomas dirk-thomas merged commit 9822bf7 into indigo-devel May 22, 2015
@dirk-thomas dirk-thomas deleted the clean_test_results_per_project branch May 22, 2015 18:58
cwecht pushed a commit to cwecht/catkin that referenced this pull request Mar 20, 2018
* Add Magazino public datasets to data.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants